Messages in this thread | | | Date | Fri, 29 Apr 2016 11:23:20 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] klp: make object/func-walking helpers more robust |
| |
On Thu, Apr 28, 2016 at 04:34:08PM +0200, Miroslav Benes wrote: > Current object-walking helper checks the presence of obj->funcs to > determine the end of objs array in klp_object structure. This is > somewhat fragile because one can easily forget about funcs definition > during livepatch creation. In such a case the livepatch module is > successfully loaded and all objects after the incorrect one are omitted. > This is very confusing. Let's make the helper more robust and check also > for the other external member, name. Thus the helper correctly stops on > an empty item of the array. We need to have a check for obj->funcs in > klp_init_object() to make it work. > > The same applies to a func-walking helper. > > As a benefit we'll check for new_func member definition during the > livepatch initialization. There is no such check anywhere in the code > now. > > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |