Messages in this thread | | | Date | Fri, 29 Apr 2016 17:12:48 +0200 | From | Grigori Goronzy <> | Subject | Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations |
| |
On 2016-04-29 14:52, Johan Hovold wrote: >> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device >> *dev, u8 control) >> >> static int ch341_get_status(struct usb_device *dev, struct >> ch341_private *priv) >> { >> - char *buffer; >> + unsigned char *buffer; >> int r; >> - const unsigned size = 8; >> + const unsigned size = 2; > > Did you reply to Oliver's comment about this change? Are you sure this > won't break some old device expecting to be asked for eight bytes even > if only two are returned? >
I'll just drop this change.
Grigori
| |