Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next] net: dsa: mv88e6xxx: replace ds with ps where possible | Date | Fri, 29 Apr 2016 10:55:26 -0400 |
| |
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> On Thu, Apr 28, 2016 at 09:24:06PM -0400, Vivien Didelot wrote: >> From: Andrew Lunn <andrew@lunn.ch> >> >> The dsa_switch structure ds is actually needed in very few places, >> mostly during setup of the switch. The private structure ps is however >> needed nearly everywhere. Pass ps, not ds internally. >> >> [vd: rebased Andrew's patch.] > > Hi Vivien > > Thanks for picking up this patch and rebasing it. > > I would generally put comments like that bellow the ---. They don't > need to be in the commit log.
I've seen that '[<initials-or-firstname>: <message>]' is often used to inject notes in the message, but that might not be a standard.
Thanks for the note,
Vivien
| |