Messages in this thread | | | Date | Fri, 29 Apr 2016 11:11:49 -0300 | From | Gustavo Padovan <> | Subject | Re: [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put() |
| |
2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:
> > > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > > These two functions are just wrappers for one line functions, they > > call fd_install() and fput() respectively, so just get rid of them > > and use fd_install() and fput() directly for more simplicity. > > > Given sync_file is not file, I don't see that simplicity is worth of > the change of 20+ lines. > Can you please specify the disadvantages of the wrappers?
Our idea here was to simplify as much as possible this API, also we do not want to hide sync_file internals from its users. This is staging and we are re-thinking the API (and userspace ABI too) before moving it out if staging. I can add some more information to the commit message.
Gustavo
| |