Messages in this thread | | | Date | Fri, 29 Apr 2016 14:22:06 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v4 03/13] USB: ch341: add definitions for modem control |
| |
On Fri, Apr 15, 2016 at 11:14:06PM +0200, Grigori Goronzy wrote:
No commit message?
> Signed-off-by: Grigori Goronzy <greg@chown.ath.cx> > --- > drivers/usb/serial/ch341.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index 1ab4384..db4b561 100644 > --- a/drivers/usb/serial/ch341.c > +++ b/drivers/usb/serial/ch341.c > @@ -61,6 +61,7 @@ > * the Net/FreeBSD uchcom.c driver by Takanori Watanabe. Domo arigato. > */ > > +#define CH341_MODEM_CTRL 0xA4
Please use the common CH341_REQ prefix and keep the requests sorted numerically.
> #define CH341_REQ_WRITE_REG 0x9A > #define CH341_REQ_READ_REG 0x95 > #define CH341_REG_BREAK1 0x05 > @@ -162,7 +163,7 @@ static int ch341_set_baudrate(struct usb_device *dev, > > static int ch341_set_handshake(struct usb_device *dev, u8 control) > { > - return ch341_control_out(dev, 0xa4, ~control, 0); > + return ch341_control_out(dev, CH341_MODEM_CTRL, ~control, 0); > } > > static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv)
Thanks, Johan
| |