lkml.org 
[lkml]   [2016]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 21/32] perf/x86/intel/cqm: handle inherit event and inherit_stat flag
Date
Since inherited events are part of the same cqm cache group, they share the
RMID and therefore they cannot provide the granularity required by
inherit_stats. Changing this would require to create a subtree of monrs for
each parent event and its inherited events, a potential improvement for
future patches.

Reviewed-by: Stephane Eranian <eranian@google.com>
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
arch/x86/events/intel/cqm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/cqm.c b/arch/x86/events/intel/cqm.c
index d8d3191..6e85021 100644
--- a/arch/x86/events/intel/cqm.c
+++ b/arch/x86/events/intel/cqm.c
@@ -2483,6 +2483,7 @@ static int intel_cqm_event_init(struct perf_event *event)
event->attr.exclude_idle ||
event->attr.exclude_host ||
event->attr.exclude_guest ||
+ event->attr.inherit_stat || /* cqm groups share rmid */
event->attr.sample_period) /* no sampling */
return -EINVAL;

--
2.8.0.rc3.226.g39d4020
\
 
 \ /
  Last update: 2016-04-29 07:01    [W:2.098 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site