lkml.org 
[lkml]   [2016]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/32] perf/x86/intel/cqm: prepare for next patches
    On Thu, Apr 28, 2016 at 09:43:14PM -0700, David Carrillo-Cisneros wrote:
    > Move code around, delete unnecesary code and do some renaming in
    > in order to increase readibility of next patches. Create cqm.h file.

    *sigh*, this is a royal pain in the backside to review.

    Please just completely wipe the old driver in patch 1, preserve
    _nothing_.

    Then start adding bits back, in gradual coherent pieces. Like that msr
    write optimization you need new hooks for, that should be a patch doing
    just that, optimize, it should not introduce new functionality etc..

    This piecewise removal of small bits makes it entirely hard to see the
    complete picture of what is introduced here.

    \
     
     \ /
      Last update: 2016-04-29 11:41    [W:4.050 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site