Messages in this thread | | | From | Olliver Schinagl <> | Subject | Re: [PATCH 00/11] NFC: pn533: bug fixes and improvements | Date | Thu, 28 Apr 2016 20:18:57 +0200 |
| |
Hi Michael,
I know i'm a little late to the party, but why did you not name the directory/driver pn53x? I don't think we should debate wether a 533 is a 532 with a USB added, or wether a 532 is a 533 with the USB stripped, I was just curious. As for the pn533-i2c, in the KConfig, I'd probably recommend naming it pn532 at the least though, since there is no variant other then USB for the 533?
Further more, I think it would be wise to add some documentation and nfc bindings examples.
I'm using it as a subnode of an i2c node as such:
&i2c2 { pinctrl-names = "default"; pinctrl-0 = <&i2c2_pins_a>; status = "okay";
pn532: pn53x@48 { compatible = "nxp,pn532-i2c"; reg = <0x48>; }; };
But not sure if this is correct at all (I haven't gotten it to work yet, partly due to a burnt level shifter). For example, I'm not sure what other properties are needed.
Olliver
On 21-04-16 16:43, Michael Thalmeier wrote: > Hello Samuel, > > This patchset fixes some major bugs in the pn533 drivers (usb and i2c) and > improves performance of the PN532 chip by increasing its clock speed. > > Best Regards > Michael > > Michael Thalmeier (11): > NFC: pn533: i2c: free irq on driver remove > NFC: pn533: fix order of initialization > NFC: pn533: i2c: do not call pn533_recv_frame with aborted commands > NFC: pn533: reset poll modulation list before calling nfc_targets_found > NFC: pn533: handle interrupted commands in pn533_recv_frame > NFC: pn533: usb: fix errors when poll is stopped > NFC: pn533: improve cmd queue handling > NFC: pn533: reduce output when stopping poll > NFC: pn533: use nfc_alloc_recv_skb for skb allocation > NFC: pn533: set cmd status when not set > nfc: pn533: increase clock frequency for PN532 > > drivers/nfc/pn533/i2c.c | 20 ++++-- > drivers/nfc/pn533/pn533.c | 154 +++++++++++++++++++++++++++++++++++++--------- > drivers/nfc/pn533/pn533.h | 5 +- > drivers/nfc/pn533/usb.c | 15 +++-- > 4 files changed, 153 insertions(+), 41 deletions(-) >
| |