Messages in this thread | | | Date | Thu, 28 Apr 2016 17:47:31 +0100 | From | One Thousand Gnomes <> | Subject | Re: [PATCH v2] x86/boot: Rename overlapping memcpy() to memmove() |
| |
O> For example, this is what I've got currently: > > /* Detect and warn about potential overlaps. */ > void *memcpy(void *dest, const void *src, size_t n) > { > if (dest > src && dest - src < n) > warn("Potentially unsafe overlapping memcpy detected!"); > return __memcpy(dest, src, n); > } > > Does that seem okay? If so, I'll send the patch...
Probably useful for debug, but instead of relying on __memcpy happening to handle overlaps - which isn't portable you could instead debug all platforms by doing
if (...) { warn(...) memmove() } else __memcpy
Alan
| |