Messages in this thread | | | From | "Chen, Yu C" <> | Subject | RE: [PATCH] cpufreq: governor: Change confusing struct field and variable names | Date | Thu, 28 Apr 2016 07:07:09 +0000 |
| |
> -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Thursday, April 28, 2016 7:19 AM > To: Linux PM list > Cc: Linux Kernel Mailing List; Viresh Kumar; Chen, Yu C > Subject: [PATCH] cpufreq: governor: Change confusing struct field and variable > names > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The name of the prev_cpu_wall field in struct cpu_dbs_info is confusing, > because it doesn't represent wall time, but the previous update time as > returned by get_cpu_idle_time() (that may be the current value of jiffies_64 in > some cases, for example). > > Moreover, the names of some related variables in dbs_update() take that > confusion further. > > Rename all of those things to make their names reflect the purpose more > accurately. While at it, drop unnecessary parens from one of the updated > expressions. > > No functional changes. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/cpufreq/cpufreq_governor.c | 22 +++++++++++----------- > drivers/cpufreq/cpufreq_governor.h | 2 +- > 2 files changed, 12 insertions(+), 12 deletions(-) Acked-by: Chen Yu <yu.c.chen@intel.com>
| |