Messages in this thread Patch in this message | | | Subject | Re: [PATCH 3/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency | From | Tero Kristo <> | Date | Wed, 27 Apr 2016 14:49:15 +0300 |
| |
On 26/04/16 20:54, J.D. Schroeder wrote: > From: "J.D. Schroeder" <jay.schroeder@garmin.com> > > This commit updates the OSC_32K_CLK (secure_32k_clk_src_ck) frequency > from the precise 32kHz frequency (i.e., 32.768 kHz) to the more > accurate frequency of ~34.6 kHz. Actual measured frequencies of the > clock vary from board to board anywhere from 34.4 kHz up to 34.8 kHz.
Uhm, if you have a board specific, accurate value for this clock, you should update it in the board file itself. This definition is going to be used across all the DRA7 / AM57xx boards, which can very likely have different crystal accuracies.
So, NAK.
-Tero
> > Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com> > Reviewed-by: Trenton Andres <trenton.andres@garmin.com> > --- > arch/arm/boot/dts/dra7xx-clocks.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi > index a514fc3..4501140 100644 > --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi > +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi > @@ -95,7 +95,7 @@ > secure_32k_clk_src_ck: secure_32k_clk_src_ck { > #clock-cells = <0>; > compatible = "fixed-clock"; > - clock-frequency = <32768>; > + clock-frequency = <34600>; /* approximate frequency */ > }; > > virt_12000000_ck: virt_12000000_ck { >
| |