lkml.org 
[lkml]   [2016]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()
Dear Russell,

On Wed, 30 Mar 2016 14:45:08 +0800 Jisheng Zhang wrote:

> Once entering machine_halt() and machine_restart(), local_irq_disable()
> is called, and local irq is kept disabled, so the local_irq_disable()
> at the end of these two functions are not necessary, remove it.

Could I put the patch in your patch tracking system?

Thanks,
Jisheng

>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>
> Since v1:
> - correct typo in commit msg
>
> arch/arm/kernel/reboot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
> index 71a2ff9..3fa867a 100644
> --- a/arch/arm/kernel/reboot.c
> +++ b/arch/arm/kernel/reboot.c
> @@ -104,8 +104,6 @@ void machine_halt(void)
> {
> local_irq_disable();
> smp_send_stop();
> -
> - local_irq_disable();
> while (1);
> }
>
> @@ -150,6 +148,5 @@ void machine_restart(char *cmd)
>
> /* Whoops - the platform was unable to reboot. Tell the user! */
> printk("Reboot failed -- System halted\n");
> - local_irq_disable();
> while (1);
> }

\
 
 \ /
  Last update: 2016-04-27 11:41    [W:0.289 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site