lkml.org 
[lkml]   [2016]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mmots 2016-04-25] hugetlb : error: ‘cpu has pse’ undeclared

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 26 Apr 2016 23:14:35 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
>
> > Hello,
> >
> > v4.6-rc5-mmots-2016-04-25-17-33
> >
> >
> > In file included from include/linux/hugetlb.h:418:0,
> > from fs/hugetlbfs/inode.c:28:
> > fs/hugetlbfs/inode.c: In function 'init_hugetlbfs_fs':
> > ./arch/x86/include/asm/hugetlb.h:7:31: error: 'cpu_has_pse' undeclared (first use in this function)
> > #define hugepages_supported() cpu_has_pse
> > ^
>
> hm, how did that happen. I had some issues with cpu_has_pse a number
> of days ago but they later went away.
>
> In my current tree I have, in arch/x86/include/asm/hugetlb.h:
>
> #define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE)
>
> and that came in from linux-next.patch. I wonder why your tree is
> different.
>
> <looks>
>
> OK, http://ozlabs.org/~akpm/mmots/broken-out/linux-next.patch has no
> changes to arch/x86/include/asm/hugetlb.h at all. Maybe I fat-fingered
> something. Odd.

So I think the reason is that cpu_has_pse is gone from the x86 devel tree, please
use this instead:

boot_cpu_has(X86_FEATURE_PSE)

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-04-27 10:21    [W:0.091 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site