Messages in this thread | | | Date | Tue, 26 Apr 2016 20:11:14 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCHv3] x86/mce: Look in genpool instead of mcelog.entry[] for pending error records |
| |
On Fri, Apr 08, 2016 at 10:00:50AM -0700, Tony Luck wrote: > Couple of issues here: > 1) MCE_LOG_LEN is only 32 - so we may have more pending records than will > fit in the buffer on high core count cpus > 2) During a panic we may have a lot of duplicate records because multiple > logical cpus may have seen and logged the same error because some > banks are shared. > > Switch to using the genpool to look for the pending records. Squeeze > out duplicated records. > > Signed-off-by: Tony Luck <tony.luck@intel.com> > --- > v3: Make mce_cmp() behave like other *cmp() functions: return 0 for equality (Boris) > > v2: Better names and code layout (Boris) > Revised commments on mce record comparisons (Ashok) > > arch/x86/kernel/cpu/mcheck/mce-genpool.c | 46 +++++++++++++++++++++++++++++++ > arch/x86/kernel/cpu/mcheck/mce-internal.h | 15 ++++++++++ > arch/x86/kernel/cpu/mcheck/mce.c | 21 ++++++-------- > 3 files changed, 70 insertions(+), 12 deletions(-)
Applied, thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |