lkml.org 
[lkml]   [2016]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv
On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> >
> Sorry. It's really a problem. I'll modify it in v2 like below:
>
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> reset_control_put(priv->rsts[rst]);
> goto err_reset;
> }

Yes, that would be good. (Except for the missing ' ' between "if" and
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern

\
 
 \ /
  Last update: 2016-04-26 17:01    [W:0.058 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site