Messages in this thread | | | Date | Tue, 26 Apr 2016 16:15:53 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] printk: make printk.synchronous param rw |
| |
On Sun 2016-04-24 00:01:05, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Reviewed-by: Jan Kara <jack@suse.cz> > --- > > -- added Jan's Reviewed-by > -- factored out async printk checks to can_printk_async() > > kernel/printk/printk.c | 56 ++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 45 insertions(+), 11 deletions(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 89f5441..9345a29 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2757,6 +2759,13 @@ static int __init printk_late_init(void) > late_initcall(printk_late_init); > > #if defined CONFIG_PRINTK > +/* > + * Prevent starting printk_kthread from start_kernel()->parse_args(). > + * It's not possible at this stage. Instead, do it via the inticall ^^^^^^^^
s/inticall/initcall/
Otherwise, it looks fine. I like the series and keep my fingers crossed.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |