lkml.org 
[lkml]   [2016]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH perf/core v4 06/19] perf-probe: Let probe_file__add_event return 0 if succeeded
Em Tue, Apr 26, 2016 at 06:03:04PM +0900, Masami Hiramatsu escreveu:
> Since other methods return 0 if succeeded (or filedesc),
> let probe_file__add_event() return 0 instead of the length
> of written bytes.

Thanks, applied.

- Arnaldo

> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/perf/util/probe-file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c
> index e3b3b92..3fe6214 100644
> --- a/tools/perf/util/probe-file.c
> +++ b/tools/perf/util/probe-file.c
> @@ -220,8 +220,7 @@ int probe_file__add_event(int fd, struct probe_trace_event *tev)
>
> pr_debug("Writing event: %s\n", buf);
> if (!probe_event_dry_run) {
> - ret = write(fd, buf, strlen(buf));
> - if (ret <= 0) {
> + if (write(fd, buf, strlen(buf)) < (int)strlen(buf)) {
> ret = -errno;
> pr_warning("Failed to write event: %s\n",
> strerror_r(errno, sbuf, sizeof(sbuf)));

\
 
 \ /
  Last update: 2016-04-26 16:01    [W:0.195 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site