lkml.org 
[lkml]   [2016]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: rk808: remove unused rk808_reg_ops_ranges
From
Date
Sorry for that.
I missed to add rk808_reg_ops_ranges in the LDO_REG3 desc
in patch afcd666d9db0


On 26.04.2016 11:19, Arnd Bergmann wrote:
> After removing all uses of the range operations in a recent patch,
> we get a warning about the symbol not being referenced anywhere:
>
> drivers/regulator/rk808-regulator.c:306:29: 'rk808_reg_ops_ranges' defined but not used
>
> This removes the now-unused structure along with the
> rk808_set_suspend_voltage_range function that is only referenced from
> rk808_reg_ops_ranges.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: afcd666d9db0 ("regulator: rk808: remove linear range definitions with a single range")
> ---
> drivers/regulator/rk808-regulator.c | 28 ----------------------------
> 1 file changed, 28 deletions(-)
>
> diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
> index 964b95eed271..67f72feed815 100644
> --- a/drivers/regulator/rk808-regulator.c
> +++ b/drivers/regulator/rk808-regulator.c
> @@ -238,21 +238,6 @@ static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
> sel);
> }
>
> -static int rk808_set_suspend_voltage_range(struct regulator_dev *rdev, int uv)
> -{
> - unsigned int reg;
> - int sel = regulator_map_voltage_linear_range(rdev, uv, uv);
> -
> - if (sel < 0)
> - return -EINVAL;
> -
> - reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET;
> -
> - return regmap_update_bits(rdev->regmap, reg,
> - rdev->desc->vsel_mask,
> - sel);
> -}
> -
> static int rk808_set_suspend_enable(struct regulator_dev *rdev)
> {
> unsigned int reg;
> @@ -303,19 +288,6 @@ static struct regulator_ops rk808_reg_ops = {
> .set_suspend_disable = rk808_set_suspend_disable,
> };
>
> -static struct regulator_ops rk808_reg_ops_ranges = {
> - .list_voltage = regulator_list_voltage_linear_range,
> - .map_voltage = regulator_map_voltage_linear_range,
> - .get_voltage_sel = regulator_get_voltage_sel_regmap,
> - .set_voltage_sel = regulator_set_voltage_sel_regmap,
> - .enable = regulator_enable_regmap,
> - .disable = regulator_disable_regmap,
> - .is_enabled = regulator_is_enabled_regmap,
> - .set_suspend_voltage = rk808_set_suspend_voltage_range,
> - .set_suspend_enable = rk808_set_suspend_enable,
> - .set_suspend_disable = rk808_set_suspend_disable,
> -};
> -
> static struct regulator_ops rk808_switch_ops = {
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,

\
 
 \ /
  Last update: 2016-04-26 12:01    [W:0.089 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site