Messages in this thread | | | Date | Tue, 26 Apr 2016 01:32:10 -0700 | From | "" <> | Subject | Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io |
| |
On Mon, Apr 25, 2016 at 11:32:08AM -0400, Jeff Moyer wrote: > > EINVAL is a concern here. Not due to the right error reported, but > > because it means your current scheme is fundamentally broken - we > > need to support I/O at any alignment for DAX I/O, and not fail due to > > alignbment concernes for a highly specific degraded case. > > > > I think this whole series need to go back to the drawing board as I > > don't think it can actually rely on using direct I/O as the EIO > > fallback. > > The only callers of dax_do_io are direct_IO methods.
They are because the DAX I/O pass is a mess, but that doesn't mean the user specific O_DIRECT on the open nessecarily.
| |