Messages in this thread | | | Date | Tue, 26 Apr 2016 14:12:59 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle |
| |
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> [160426 14:08]: > On Tue, Apr 26, 2016 at 01:46:15PM -0700, Tony Lindgren wrote: > > * Paul E. McKenney <paulmck@linux.vnet.ibm.com> [160426 13:42]: > > > On Tue, Apr 26, 2016 at 01:25:39PM -0700, Tony Lindgren wrote: > > > > * Paul E. McKenney <paulmck@linux.vnet.ibm.com> [160426 13:12]: > > > > > On Tue, Apr 26, 2016 at 01:06:13PM -0700, Paul E. McKenney wrote: > > > > > > On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote: > > > > > > > * Steven Rostedt <rostedt@goodmis.org> [160426 12:45]: > > > > > > > > *Whack* *Whack* *Whack*!!! > > > > > > > > > > > > > > > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > > > > > > > > --- > > > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > > > > > index fb74dc1f7520..4fa43c02d682 100644 > > > > > > > > --- a/drivers/clk/clk.c > > > > > > > > +++ b/drivers/clk/clk.c > > > > > > > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > > > > > > > > if (--core->enable_count > 0) > > > > > > > > return; > > > > > > > > > > > > > > > > - trace_clk_disable(core); > > > > > > > > + trace_clk_disable_rcuidle(core); > > > > > > > > > > > > > > > > if (core->ops->disable) > > > > > > > > core->ops->disable(core->hw); > > > > > > > > > > > > > > > > - trace_clk_disable_complete(core); > > > > > > > > + trace_clk_disable_complete_rcuidle(core); > > > > > > > > > > > > > > > > clk_core_disable(core->parent); > > > > > > > > } > > > > > > > > > > > > > > Now the mole shows up here! > > > > > > > > > > > > And the patch shows up here! > > > > > > > > > > And I bet you will need this one as well... > > > > > > > > OK and now the mode is coming back after a short nap during idle: > > > > > > Seems a bit unfair to whack it just after a short nap, but here goes! > > > > This mode seems pretty hard headed :) Now clk_core_enable: > > Nah, just a lot of heads...
OK that does it for me. Thanks for all the mole related whacks, please feel free to add:
Tested-by: Tony Lindgren <tony@atomide.com>
| |