Messages in this thread | | | Date | Mon, 25 Apr 2016 09:52:22 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests |
| |
On Mon, 25 Apr 2016, Jan Beulich wrote: > >>> On 22.04.16 at 20:03, <hpa@zytor.com> wrote: > >> +#define hugepages_supported() cpu_has_pse > >> > > > > Please don't use the cpu_has_* macros anymore, they are going away soon. > > > > In this case it should be static_cpu_has(X86_FEATURE_PSE). > > I can certainly do that, but this > - will (mildly) harm backportability > - imo should have been requested much earlier (when the patch was > still under discussion)
It's requested now as cpu_has_* is going away. So instead of making silly arguments you should have sent a delta patch fixing this.
Thanks,
tglx
| |