lkml.org 
[lkml]   [2016]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests
On Mon, 25 Apr 2016, Jan Beulich wrote:
> >>> On 22.04.16 at 20:03, <hpa@zytor.com> wrote:
> >> +#define hugepages_supported() cpu_has_pse
> >>
> >
> > Please don't use the cpu_has_* macros anymore, they are going away soon.
> >
> > In this case it should be static_cpu_has(X86_FEATURE_PSE).
>
> I can certainly do that, but this
> - will (mildly) harm backportability
> - imo should have been requested much earlier (when the patch was
> still under discussion)

It's requested now as cpu_has_* is going away. So instead of making silly
arguments you should have sent a delta patch fixing this.

Thanks,

tglx

\
 
 \ /
  Last update: 2016-04-25 10:21    [W:0.067 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site