lkml.org 
[lkml]   [2016]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] usb: gadget: NCM: NULL pointer dereference in eth_start_xmit
On Mon, 25 Apr 2016 16:25:03 +0100
<jim_baxter@mentor.com> wrote:

> From: Jim Baxter <jim_baxter@mentor.com>
>
> "Unable to handle kernel NULL pointer dereference at virtual address
> 00000078" is reported with "PC is at eth_start_xmit+0x19c/0x378 [u_ether]"
>
> The failure scenario is seen when closing the NCM connection while the
> TCP/IPv6 stack is still trying to transmit over NCM.
>
> Defensive code is missing from commit
> 6d3865f9d41f15ddbcecaa6722871fc0db21d7ab
> "usb: gadget: NCM: Add transmit multi-frame."

This looks inadequate. Surely you also need to hold dev->lock ?

Also it'll also crash at the no zlp test with the same problem.

Alan

\
 
 \ /
  Last update: 2016-04-25 19:01    [W:0.040 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site