Messages in this thread | | | Date | Mon, 25 Apr 2016 15:15:57 +0100 | From | Matt Fleming <> | Subject | Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption |
| |
On Mon, 25 Apr, at 03:12:01PM, Robin Murphy wrote: > >+static void efi_call_virt_check_flags(unsigned long flags, const char *call) > >+{ > >+ unsigned long cur_flags; > >+ bool mismatch; > >+ > >+ local_save_flags(cur_flags); > >+ > >+ mismatch = !!((cur_flags ^ flags) & ARCH_EFI_IRQ_FLAGS_MASK); > > nit: the assignment itself is already a conversion to bool, so the > excitement is redundant here.
This was intentional. I asked Mark to make this change so that it's explicit for the developer that we're performing the type conversion.
| |