Messages in this thread | | | Subject | Re: [PATCH] fs: fix over-zealous use of "const" | From | Andy Shevchenko <> | Date | Mon, 25 Apr 2016 12:03:00 +0300 |
| |
On Thu, 2016-04-21 at 12:53 -0700, Kees Cook wrote: > When I was fixing up const recommendations from checkpatch.pl, I went > overboard. This fixes the warning (during a W=1 build): > > include/linux/fs.h:2627:74: warning: type qualifiers ignored on > function return type [-Wignored-qualifiers] > static inline const char * const kernel_read_file_id_str(enum > kernel_read_file_id id) > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Kees Cook <keescook@chromium.org> > --- > This is for linux-security next > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 518716b4834e..82f9a2db3b1a 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2610,7 +2610,7 @@ static const char * const kernel_read_file_str[] > = { > __kernel_read_file_id(__fid_stringify) > }; > > -static inline const char * const kernel_read_file_id_str(enum > kernel_read_file_id id) > +static inline const char *kernel_read_file_id_str(enum > kernel_read_file_id id) > { > if (id < 0 || id >= READING_MAX_ID) > return kernel_read_file_str[READING_UNKNOWN]; > -- > 2.6.3 > >
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |