lkml.org 
[lkml]   [2016]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] skd: remove broken discard support
From
Date

> On Apr 25, 2016, at 4:06 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Simply creating a file system on an skd device, followed by mount and
> fstrim will result in errors in the logs and then a BUG(). Let's remove
> discard support from that driver. As far as I can tell, it hasn't
> worked right since it was merged. This patch also has a side-effect of
> cleaning up an unintentional shadowed declaration inside of
> skd_end_request.
>
> I tested to ensure that I can still do I/O to the device using xfstests
> ./check -g quick. I didn't do anything more extensive than that,
> though.

Applied, thanks Jeff.

--
Jens Axboe

\
 
 \ /
  Last update: 2016-04-26 04:01    [W:0.032 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site