Messages in this thread | | | Date | Sun, 24 Apr 2016 14:18:06 -0400 (EDT) | Subject | Re: [PATCH 1/6] bus: Add shared MDIO bus framework | From | David Miller <> |
| |
From: Pramod Kumar <pramod.kumar@broadcom.com> Date: Thu, 21 Apr 2016 14:48:38 +0530
> +struct shared_mdio_master *shared_mdio_alloc_master(struct device *parent, > + struct device_node *node) > +{ > + int ret = 0; > + struct shared_mdio_master *master;
Always order local variable declarations in reverse christmas tree (longest to shortest line) order.
> +static int shared_mdio_driver_probe(struct device *dev) > +{ > + int rc; > + struct shared_mdio_master *master = to_shared_mdio_master(dev); > + struct shared_mdio_driver *drv = to_shared_mdio_driver(dev->driver);
Likewise.
Please audit your entire submission for this issue.
| |