lkml.org 
[lkml]   [2016]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver
    Date
    On Thursday 21 April 2016 14:29:02 Viresh Kumar wrote:
    > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
    > index 79d0a5d9da8e..f24f46776fbb 100644
    > --- a/arch/arm/mach-mvebu/pmsu.c
    > +++ b/arch/arm/mach-mvebu/pmsu.c
    > @@ -685,8 +685,6 @@ static int __init armada_xp_pmsu_cpufreq_init(void)
    > dev_err(cpu_dev, "%s: failed to mark OPPs as shared: %d\n",
    > __func__, ret);
    > }
    > -
    > - platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
    > return 0;
    > }
    >
    > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
    > index 69b2a222c84e..5704a92c52dc 100644
    > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
    > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
    > @@ -33,6 +33,8 @@ static const struct of_device_id machines[] = {
    >
    > { .compatible = "marvell,berlin", },
    >
    > + { .compatible = "marvell,armadaxp", },
    > +
    > { .compatible = "samsung,exynos3250", },
    > { .compatible = "samsung,exynos4210", },
    > { .compatible = "samsung,exynos4212", },

    I think to make it clear that the ordering is significant here, I would leave this
    platform_device_register_simple() in armada_xp_pmsu_cpufreq_init().

    However, it might be helpful to move that function into a new file in
    drivers/cpufreq/ if that works.

    Arnd

    \
     
     \ /
      Last update: 2016-04-23 01:01    [W:5.634 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site