Messages in this thread Patch in this message | | | Date | Fri, 22 Apr 2016 15:12:19 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] VPU: mediatek: fix simple_open.cocci warnings |
| |
Remove an open coded simple_open() function and replace file operations references to the function with simple_open() instead.
Generated by: scripts/coccinelle/api/simple_open.cocci
CC: Andrew-CT Chen <andrew-ct.chen@mediatek.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> ---
I'm just passing this along. Simple_open additionally has a check that inode->i_private is not NULL, before doing the assignment. I don't know if that difference is important in this case.
base: git://linuxtv.org/media_tree.git master
mtk_vpu.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
--- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -599,11 +599,6 @@ static void vpu_init_ipi_handler(void *d }
#ifdef CONFIG_DEBUG_FS -static int vpu_debug_open(struct inode *inode, struct file *file) -{ - file->private_data = inode->i_private; - return 0; -}
static ssize_t vpu_debug_read(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) @@ -646,7 +641,7 @@ static ssize_t vpu_debug_read(struct fil }
static const struct file_operations vpu_debug_fops = { - .open = vpu_debug_open, + .open = simple_open, .read = vpu_debug_read, }; #endif /* CONFIG_DEBUG_FS */
| |