lkml.org 
[lkml]   [2016]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] asus-laptop: correct error handling in asus_read_brightness()
From
On Sat, Apr 16, 2016 at 3:27 AM, Giedrius Statkevičius
<giedrius.statkevicius@gmail.com> wrote:
> It is possible that acpi_evaluate_integer might fail and value would not be
> set to any value so correct this defect by returning 0 in case of an
> error. This is also the correct thing to return because the backlight
> subsystem will print the old value of brightness in this case.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 9a69734..15f1311 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -775,8 +775,10 @@ static int asus_read_brightness(struct backlight_device *bd)
>
> rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET,
> NULL, &value);
> - if (ACPI_FAILURE(rv))
> + if (ACPI_FAILURE(rv)) {
> pr_warn("Error reading brightness\n");
> + return 0;
> + }

This looks like a workaround.
I suppose the real fix is to return here an error code and fix all callers, like
drivers/video/backlight/backlight.c.

>
> return value;
> }
> --
> 2.8.0
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2016-04-22 01:41    [W:0.061 / U:2.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site