Messages in this thread | | | Date | Thu, 21 Apr 2016 13:59:09 -0700 | From | Darren Hart <> | Subject | Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set |
| |
On Thu, Apr 21, 2016 at 11:34:13PM +0300, Andy Shevchenko wrote: > On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius > <giedrius.statkevicius@gmail.com> wrote: > > Properly return rv back to the caller in the case of an error in > > parse_arg. In the process remove a unused variable 'out'. > > > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> > > --- > > drivers/platform/x86/asus-laptop.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > > index d86d42e..9a69734 100644 > > --- a/drivers/platform/x86/asus-laptop.c > > +++ b/drivers/platform/x86/asus-laptop.c > > @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus, > > const char *method) > > { > > int rv, value; > > - int out = 0; > > > > rv = parse_arg(buf, count, &value); > > Just noticed (might be a separate patch for this) that parse_arg > pretty much duplicated kstrotint().
Ah, thanks Andy.
I'd like to take this one as is, but a cleanup for that would be welcome indeed.
-- Darren Hart Intel Open Source Technology Center
| |