Messages in this thread | | | Subject | Re: [Cocci] coccinelle: bool if (foo) return true; else return false; | From | Michael Stefaniuc <> | Date | Wed, 20 Apr 2016 09:19:20 +0200 |
| |
On 04/19/2016 09:15 PM, Julia Lawall wrote: > > > On Tue, 19 Apr 2016, Joe Perches wrote: > >> There's ~150 of these in the kernel. >> >> Maybe there's use for this conversion to be added >> to scripts/coccinelle/misc/boolreturn.cocci or in >> a separate file. >> >> $ cat booltruefalse.cocci >> @@ >> identifier fn; >> expression e; >> typedef bool; >> symbol true; >> symbol false; >> @@ >> >> bool fn ( ... ) >> { >> <... >> - if (e) return true; else return false; >> + return e; Shouldn't that be: return !!e ?
>> ...> >> } >> >> @@ >> identifier fn; >> expression e; >> @@ >> >> bool fn ( ... ) >> { >> <... >> - if (e) return false; else return true; >> + return !e; >> ...> >> } > > Thanks for the suggestion. I will take care of it shortly.
bye michael
| |