Messages in this thread | | | Date | Tue, 19 Apr 2016 21:15:54 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: coccinelle: bool if (foo) return true; else return false; |
| |
On Tue, 19 Apr 2016, Joe Perches wrote:
> There's ~150 of these in the kernel. > > Maybe there's use for this conversion to be added > to scripts/coccinelle/misc/boolreturn.cocci or in > a separate file. > > $ cat booltruefalse.cocci > @@ > identifier fn; > expression e; > typedef bool; > symbol true; > symbol false; > @@ > > bool fn ( ... ) > { > <... > - if (e) return true; else return false; > + return e; > ...> > } > > @@ > identifier fn; > expression e; > @@ > > bool fn ( ... ) > { > <... > - if (e) return false; else return true; > + return !e; > ...> > }
Thanks for the suggestion. I will take care of it shortly.
julia
| |