lkml.org 
[lkml]   [2016]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RESEND PATCH v2 3/5] security: Introduce security_settime64()
From
On Mon, Apr 18, 2016 at 9:54 AM, John Stultz <john.stultz@linaro.org> wrote:
> On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@linaro.org> wrote:
>> security_settime() uses a timespec, which is not year 2038 safe
>> on 32bit systems. Thus this patch introduces the security_settime64()
>> function with timespec64 type. We also convert the cap_settime() helper
>> function to use the 64bit types.
>>
>> Move the security_settime() to the head file as a inline function for
>> removing that inline helper when following up patches are fixed the
>> call sites.
>>
>> None of the existing hooks is using the timespec argument and therefor
>> the patch is not doing any functional changes.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>
> Hey Baolin,
> If you get an ack, like you did from James, please include it in the
> commit message of following submissions
>
> Serge, Kees: Any objection to this patch going in via the
> tip/timers/core tree with the dependent settimeofday64 call?

No problem from me: makes sense to keep it all together in one tree.

-Kees

>
> Otherwise I'll queue this up for testing.
>
> thanks
> -john
>
>
> .



--
Kees Cook
Chrome OS & Brillo Security

\
 
 \ /
  Last update: 2016-04-18 19:21    [W:0.087 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site