Messages in this thread | | | Subject | Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver | From | Stephen Warren <> | Date | Mon, 18 Apr 2016 10:29:53 -0600 |
| |
On 04/18/2016 02:46 AM, Laxman Dewangan wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy.
This seems fine as far as it goes, but if it's worth doing this, please move all the globals into the GPIO chip rather than just one of the 7 globals.
| |