Messages in this thread | | | Date | Fri, 15 Apr 2016 10:24:06 +0200 | Subject | Re: [PATCH 4/4] pinctrl: iproc: Allow PINCONF to be disabled completely | From | Linus Walleij <> |
| |
On Wed, Apr 13, 2016 at 2:15 AM, Ray Jui <ray.jui@broadcom.com> wrote:
> In some of the future iProc based SoCs, pinconf is handled by another > block and the iProc GPIO controller is solely used as a GPIO controller. > This patch adds support of a new compatible string "brcm,iproc-gpio-only", > that is introduced to handle this case, where pinconf functions in this > driver are completely disabled > > Signed-off-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> > Reviewed-by: Jon Mason <jon.mason@broadcom.com> > Reviewed-by: Scott Branden <scott.branden@broadcom.com>
If this was entirely true, then the driver should end up only executing [devm_]gpiochip_add_data() but that does not seem to be the case.
You are still registering a pin controller, right? Just disabling some of the pin config options. The pin multiplexing is still there, right? Then it is not "solely a GPIO controller". Not at all.
This patch set needs some elaboration I think.
Yours, Linus Walleij
| |