Messages in this thread | | | Subject | Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping | From | Dmitry Safonov <> | Date | Fri, 15 Apr 2016 15:08:12 +0300 |
| |
On 04/15/2016 12:51 PM, Dmitry Safonov wrote: > On 04/15/2016 12:18 PM, Ingo Molnar wrote: >> * Andy Lutomirski <luto@amacapital.net> wrote: >>> Instead of ifdef, use the (grossly misnamed) is_ia32_task() helper for >>> this, please. >> Please also let's do the rename. > Does `is_32bit_syscall` sounds right, or shall it be `is_32bit_task`? > I think, `is_compat_task` will be bad-named for X86_32 host. > Or maybe, better: is_x32_task => in_x32_syscall is_ia32_task => in_ia32_syscall as existing in_compat_syscall().
Looks good?
-- Regards, Dmitry Safonov
| |