Messages in this thread | | | Date | Fri, 15 Apr 2016 11:36:42 +0200 | Subject | Re: [PATCH] mmc: reduce nesting and join error strings into one line | From | Ulf Hansson <> |
| |
On 15 April 2016 at 11:30, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > 2016-04-15 18:26 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>: >> On 15 April 2016 at 11:01, Masahiro Yamada >> <yamada.masahiro@socionext.com> wrote: >>> Hi Ulf, >>> >>> No interest in this clean-up? >>> >> >> Well, no. >> >> Don't get me wrong, I am interested in clean-ups, but this doesn't >> improve code quality that much. >> > > At least, current code splits the error message string into two lines. > >
Yes, and that minor improvement also makes it more cumbersome to use "git blame" when trying to understand why something was changed.
Hopes that clarifies how I think. It's balance. :-)
Kind regards Uffe
| |