lkml.org 
[lkml]   [2016]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V2 01/15] coresight: tmc: modifying naming convention
    From
    Date
    On 12/04/16 18:54, Mathieu Poirier wrote:
    > According to the TMC architectural state machine, the 'stopped'
    > state is reached when bit 2 (TMCReady) of the TMC Status register
    > turns to '1'. The code is correct but the naming convention isn't.
    >
    > The 'Triggered' bit occupies position '1' of the TMC Status register
    > and has nothing to do with the indication of the TMC entering the
    > stopped state. As such renaming function "tmc_wait_for_triggered()"
    > and changing the #define to reflect what the code is really doing.
    >
    > This patch has no effect other than clarifying the semantic.
    >
    > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

    Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

    Suzuki

    \
     
     \ /
      Last update: 2016-04-14 19:21    [W:4.066 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site