lkml.org 
[lkml]   [2016]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [RFC PATCH v2 5/5] ASoC: mediatek: Add mt2701-cs42448 driver and config option.
From
Date
On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote:
> Add machine driver and config option for MT2701.
>
> Signed-off-by: Garlic Tseng <garlic.tseng@mediatek.com>
> ---
> sound/soc/mediatek/Kconfig | 21 ++
> sound/soc/mediatek/Makefile | 3 +
> sound/soc/mediatek/mt2701/Makefile | 20 ++
> sound/soc/mediatek/mt2701/mt2701-cs42448.c | 376 +++++++++++++++++++++++++++++
> 4 files changed, 420 insertions(+)
> create mode 100644 sound/soc/mediatek/mt2701/Makefile
> create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c
>
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index f7e789e..b190322 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -48,3 +48,24 @@ config SND_SOC_MT8173_RT5650_RT5676
> with the RT5650 and RT5676 codecs.
> Select Y if you have such device.
> If unsure select "N".
> +
> +config SND_SOC_MT2701

It seems we need different driver for different soc. So after this
patch, SND_SOC_MEDIATEK only select driver for mt8173. Maybe it should
be renamed to SND_SOC_MT8173 to reflect this.

> + bool "SND_SOC_MT2701"


Please check other config in this file and have a proper config prompt
here.

Can we support module like mt8173?

> + depends on SND_SOC_MEDIATEK
> + select SND_SOC_CS42XX8_I2C
> + help
> + This adds ASoC driver for Mediatek MT2701 boards
> + with the CS42448 codecs.
> + Select Y if you have such device.
> + If unsure select "N".


Based on the Makefile, this is platform driver for mt2701. This should
not depends on codec. Please update the help message and select.

> +
> +config SND_SOC_MT2701_CS42448
> + bool "SND_SOC_MT2701_CS42448"
> + depends on SND_SOC_MT2701
> + select SND_SOC_CS42XX8_I2C
> + help
> + This adds ASoC driver for Mediatek MT2701 boards
> + with the CS42448 codecs.
> + Select Y if you have such device.
> + If unsure select "N".
> +
> diff --git a/sound/soc/mediatek/Makefile b/sound/soc/mediatek/Makefile
> index 5048165..60387ca 100644
> --- a/sound/soc/mediatek/Makefile
> +++ b/sound/soc/mediatek/Makefile
> @@ -3,3 +3,6 @@ obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173/
> obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173/
> obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5514) += mt8173/
> obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173/
> +
> +# 2701 Machine support
> +obj-$(CONFIG_SND_SOC_MT2701_CS42448) += mt2701/

Sorting, please put mt2701 before mt8173.

Joe.C


\
 
 \ /
  Last update: 2016-04-14 15:01    [W:0.068 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site