Messages in this thread | | | Date | Thu, 14 Apr 2016 11:01:35 +0100 | From | Charles Keepax <> | Subject | Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read() |
| |
On Thu, Apr 14, 2016 at 12:40:55PM +0300, Dan Carpenter wrote: > This is harmless because the function is not called, but we're trying to > return negative error codes so the function needs to return an int > instead of a u16. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
That patch looks fine, but the function appears to be completely unused, perhaps just a patch to remove it would be better?
Thanks, Charles
| |