lkml.org 
[lkml]   [2016]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 01/15] coresight: tmc: modifying naming convention
    Date
    According to the TMC architectural state machine, the 'stopped'
    state is reached when bit 2 (TMCReady) of the TMC Status register
    turns to '1'. The code is correct but the naming convention isn't.

    The 'Triggered' bit occupies position '1' of the TMC Status register
    and has nothing to do with the indication of the TMC entering the
    stopped state. As such renaming function "tmc_wait_for_triggered()"
    and changing the #define to reflect what the code is really doing.

    This patch has no effect other than clarifying the semantic.

    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    ---
    drivers/hwtracing/coresight/coresight-tmc.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
    index 2b42ecbd8831..3f646e29a99b 100644
    --- a/drivers/hwtracing/coresight/coresight-tmc.c
    +++ b/drivers/hwtracing/coresight/coresight-tmc.c
    @@ -77,7 +77,7 @@
    #define TMC_FFCR_TRIGON_TRIGIN BIT(8)
    #define TMC_FFCR_STOP_ON_FLUSH BIT(12)

    -#define TMC_STS_TRIGGERED_BIT 2
    +#define TMC_STS_TMCREADY_BIT 2
    #define TMC_FFCR_FLUSHMAN_BIT 6

    enum tmc_config_type {
    @@ -132,11 +132,11 @@ struct tmc_drvdata {
    u32 trigger_cntr;
    };

    -static void tmc_wait_for_ready(struct tmc_drvdata *drvdata)
    +static void tmc_wait_for_tmcready(struct tmc_drvdata *drvdata)
    {
    /* Ensure formatter, unformatter and hardware fifo are empty */
    if (coresight_timeout(drvdata->base,
    - TMC_STS, TMC_STS_TRIGGERED_BIT, 1)) {
    + TMC_STS, TMC_STS_TMCREADY_BIT, 1)) {
    dev_err(drvdata->dev,
    "timeout observed when probing at offset %#x\n",
    TMC_STS);
    @@ -160,7 +160,7 @@ static void tmc_flush_and_stop(struct tmc_drvdata *drvdata)
    TMC_FFCR);
    }

    - tmc_wait_for_ready(drvdata);
    + tmc_wait_for_tmcready(drvdata);
    }

    static void tmc_enable_hw(struct tmc_drvdata *drvdata)
    --
    2.5.0
    \
     
     \ /
      Last update: 2016-04-12 20:21    [W:2.573 / U:1.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site