Messages in this thread Patch in this message | | | Date | Tue, 12 Apr 2016 12:49:31 -0400 (EDT) | From | Bob Peterson <> | Subject | Re: [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes |
| |
----- Original Message ----- > This function compiles to 522 bytes of machine code. > > Error paths are not very time critical. > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Steven Whitehouse <swhiteho@redhat.com> > CC: Bob Peterson <rpeterso@redhat.com> > CC: cluster-devel@redhat.com > CC: linux-kernel@vger.kernel.org > --- > fs/gfs2/glock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c > index 6539131..c3d5172 100644 > --- a/fs/gfs2/glock.c > +++ b/fs/gfs2/glock.c > @@ -218,7 +218,7 @@ static void gfs2_holder_wake(struct gfs2_holder *gh) > * > */ > > -static inline void do_error(struct gfs2_glock *gl, const int ret) > +static void do_error(struct gfs2_glock *gl, const int ret) > { > struct gfs2_holder *gh, *tmp; > > -- > 2.1.0 > >
Hi,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=a527b38e1475211b67eb59b3fadb40689f035529
Regards,
Bob Peterson Red Hat File Systems
| |