Messages in this thread | | | Date | Tue, 12 Apr 2016 16:51:37 +0200 | From | Michal Hocko <> | Subject | Re: mmotm woes, mainly compaction |
| |
On Tue 12-04-16 14:10:20, Michal Hocko wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6d1da0ceaf1e..d80c9755ffc7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3030,8 +3030,8 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags, > * failure could be caused by weak migration mode. > */ > if (compaction_failed(compact_result)) { > - if (*migrate_mode == MIGRATE_ASYNC) { > - *migrate_mode = MIGRATE_SYNC_LIGHT; > + if (*migrate_mode < MIGRATE_SYNC) { > + *migrate_mode++; > return true;
this should be (*migrate_mode)++ of course.
> } > return false;
-- Michal Hocko SUSE Labs
| |