Messages in this thread | | | Subject | Re: [PATCH net v2] net: sched: do not requeue a NULL skb | From | Eric Dumazet <> | Date | Mon, 11 Apr 2016 11:30:56 -0700 |
| |
On Mon, 2016-04-11 at 11:26 -0700, Eric Dumazet wrote: > On Mon, 2016-04-11 at 11:02 -0700, Cong Wang wrote: > > > I am fine with either way as long as the loop stops on failure.
Note that skb that could not be validated is already freed.
So I do not see any value from stopping the loop, since we need to schedule the queue to avoid tx hang.
Just process following skb if there is one, fact that skb is sent or dropped does not matter.
| |