lkml.org 
[lkml]   [2016]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/9] net: mediatek: update the IRQ part of the binding document
    On Thu, Apr 07, 2016 at 07:57:48PM +0200, John Crispin wrote:
    > The current binding document only describes a single interrupt. Update the
    > document by adding the 2 other interrupts.
    >
    > The driver currently only uses a single interrupt. The HW is however able
    > to using IRQ grouping to split TX and RX onto separate GIC irqs.

    I assume you aren't breaking existing DTs, and the driver will continue
    to work with a single irq specified?

    >
    > Signed-off-by: John Crispin <blogic@openwrt.org>
    > Cc: devicetree@vger.kernel.org
    > ---
    > Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
    > 1 file changed, 4 insertions(+), 2 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
    > index 5ca7929..2f142be 100644
    > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
    > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
    > @@ -9,7 +9,7 @@ have dual GMAC each represented by a child node..
    > Required properties:
    > - compatible: Should be "mediatek,mt7623-eth"
    > - reg: Address and length of the register set for the device
    > -- interrupts: Should contain the frame engines interrupt
    > +- interrupts: Should contain the three frame engines interrupts

    Need to define what each irq is and the order.

    > - clocks: the clock used by the core
    > - clock-names: the names of the clock listed in the clocks property. These are
    > "ethif", "esw", "gp2", "gp1"
    > @@ -42,7 +42,9 @@ eth: ethernet@1b100000 {
    > <&ethsys CLK_ETHSYS_GP2>,
    > <&ethsys CLK_ETHSYS_GP1>;
    > clock-names = "ethif", "esw", "gp2", "gp1";
    > - interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>;
    > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW
    > + GIC_SPI 199 IRQ_TYPE_LEVEL_LOW
    > + GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
    > power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
    > resets = <&ethsys MT2701_ETHSYS_ETH_RST>;
    > reset-names = "eth";
    > --
    > 1.7.10.4
    > --
    > To unsubscribe from this list: send the line "unsubscribe devicetree" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    \
     
     \ /
      Last update: 2016-04-11 18:01    [W:4.300 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site