lkml.org 
[lkml]   [2016]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/19] arm: get rid of superfluous __GFP_REPEAT
    Date
    From: Michal Hocko <mhocko@suse.com>

    __GFP_REPEAT has a rather weak semantic but since it has been introduced
    around 2.6.12 it has been ignored for low order allocations.

    PGALLOC_GFP uses __GFP_REPEAT but none of the allocation which uses
    this flag is for more than order-2. This means that this flag has never
    been actually useful here because it has always been used only for
    PAGE_ALLOC_COSTLY requests.

    Cc: Russell King <linux@arm.linux.org.uk>
    Cc: linux-arch@vger.kernel.org
    Signed-off-by: Michal Hocko <mhocko@suse.com>
    ---
    arch/arm/include/asm/pgalloc.h | 2 +-
    arch/arm/mm/pgd.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h
    index 20febb368844..b2902a5cd780 100644
    --- a/arch/arm/include/asm/pgalloc.h
    +++ b/arch/arm/include/asm/pgalloc.h
    @@ -57,7 +57,7 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd)
    extern pgd_t *pgd_alloc(struct mm_struct *mm);
    extern void pgd_free(struct mm_struct *mm, pgd_t *pgd);

    -#define PGALLOC_GFP (GFP_KERNEL | __GFP_NOTRACK | __GFP_REPEAT | __GFP_ZERO)
    +#define PGALLOC_GFP (GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO)

    static inline void clean_pte_table(pte_t *pte)
    {
    diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c
    index b8d477321730..c1c1a5c67da1 100644
    --- a/arch/arm/mm/pgd.c
    +++ b/arch/arm/mm/pgd.c
    @@ -23,7 +23,7 @@
    #define __pgd_alloc() kmalloc(PTRS_PER_PGD * sizeof(pgd_t), GFP_KERNEL)
    #define __pgd_free(pgd) kfree(pgd)
    #else
    -#define __pgd_alloc() (pgd_t *)__get_free_pages(GFP_KERNEL | __GFP_REPEAT, 2)
    +#define __pgd_alloc() (pgd_t *)__get_free_pages(GFP_KERNEL, 2)
    #define __pgd_free(pgd) free_pages((unsigned long)pgd, 2)
    #endif

    --
    2.8.0.rc3
    \
     
     \ /
      Last update: 2016-04-11 13:41    [W:4.105 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site