lkml.org 
[lkml]   [2016]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/19] crypto: get rid of superfluous __GFP_REPEAT
    Date
    From: Michal Hocko <mhocko@suse.com>

    __GFP_REPEAT has a rather weak semantic but since it has been introduced
    around 2.6.12 it has been ignored for low order allocations.

    lzo_init uses __GFP_REPEAT to allocate LZO1X_MEM_COMPRESS 16K. This is
    order 3 allocation request and __GFP_REPEAT is ignored for this size
    as well as all <= PAGE_ALLOC_COSTLY requests.

    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Cc: "David S. Miller" <davem@davemloft.net>
    Signed-off-by: Michal Hocko <mhocko@suse.com>
    ---
    crypto/lzo.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/crypto/lzo.c b/crypto/lzo.c
    index 4b3e92525dac..c3f3dd9a28c5 100644
    --- a/crypto/lzo.c
    +++ b/crypto/lzo.c
    @@ -32,7 +32,7 @@ static int lzo_init(struct crypto_tfm *tfm)
    struct lzo_ctx *ctx = crypto_tfm_ctx(tfm);

    ctx->lzo_comp_mem = kmalloc(LZO1X_MEM_COMPRESS,
    - GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);
    + GFP_KERNEL | __GFP_NOWARN);
    if (!ctx->lzo_comp_mem)
    ctx->lzo_comp_mem = vmalloc(LZO1X_MEM_COMPRESS);
    if (!ctx->lzo_comp_mem)
    --
    2.8.0.rc3
    \
     
     \ /
      Last update: 2016-04-11 13:21    [W:6.426 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site