lkml.org 
[lkml]   [2016]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 128/238] ALSA: hda - Fix missing ELD update at unplugging
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit c64c1437afb14ebc900e40910f31ffb20bf652ad upstream.

    i915 get_eld ops may return an error when no encoder is connected, and
    currently we regard the error as fatal and skip the whole ELD
    handling. This ended up with the missing ELD update at unplugging.

    This patch fixes the issue by treating the error as the unplugged
    state, instead of skipping the rest.

    Reported-by: Libin Yang <libin.yang@linux.intel.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/patch_hdmi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/sound/pci/hda/patch_hdmi.c
    +++ b/sound/pci/hda/patch_hdmi.c
    @@ -1670,11 +1670,10 @@ static void sync_eld_via_acomp(struct hd
    int size;

    mutex_lock(&per_pin->lock);
    + eld->monitor_present = false;
    size = snd_hdac_acomp_get_eld(&codec->bus->core, per_pin->pin_nid,
    &eld->monitor_present, eld->eld_buffer,
    ELD_MAX_SIZE);
    - if (size < 0)
    - goto unlock;
    if (size > 0) {
    size = min(size, ELD_MAX_SIZE);
    if (snd_hdmi_parse_eld(codec, &eld->info,

    \
     
     \ /
      Last update: 2016-04-10 23:01    [W:4.199 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site