lkml.org 
[lkml]   [2016]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 184/210] target: Fix target_release_cmd_kref shutdown comp leak
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Himanshu Madhani <himanshu.madhani@qlogic.com>

    commit 5e47f1985d7107331c3f64fb3ec83d66fd73577e upstream.

    This patch fixes an active I/O shutdown bug for fabric
    drivers using target_wait_for_sess_cmds(), where se_cmd
    descriptor shutdown would result in hung tasks waiting
    indefinitely for se_cmd->cmd_wait_comp to complete().

    To address this bug, drop the incorrect list_del_init()
    usage in target_wait_for_sess_cmds() and always complete()
    during se_cmd target_release_cmd_kref() put, in order to
    let caller invoke the final fabric release callback
    into se_cmd->se_tfo->release_cmd() code.

    Reported-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
    Tested-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/target/target_core_transport.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/target/target_core_transport.c
    +++ b/drivers/target/target_core_transport.c
    @@ -2618,8 +2618,6 @@ void target_wait_for_sess_cmds(struct se

    list_for_each_entry_safe(se_cmd, tmp_cmd,
    &se_sess->sess_wait_list, se_cmd_list) {
    - list_del_init(&se_cmd->se_cmd_list);
    -
    pr_debug("Waiting for se_cmd: %p t_state: %d, fabric state:"
    " %d\n", se_cmd, se_cmd->t_state,
    se_cmd->se_tfo->get_cmd_state(se_cmd));

    \
     
     \ /
      Last update: 2016-04-10 21:21    [W:4.240 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site