lkml.org 
[lkml]   [2016]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 061/238] USB: digi_acceleport: do sanity checking for the number of ports
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Oliver Neukum <oneukum@suse.com>

    commit 5a07975ad0a36708c6b0a5b9fea1ff811d0b0c1f upstream.

    The driver can be crashed with devices that expose crafted descriptors
    with too few endpoints.

    See: http://seclists.org/bugtraq/2016/Mar/61

    Signed-off-by: Oliver Neukum <ONeukum@suse.com>
    [johan: fix OOB endpoint check and add error messages ]
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/digi_acceleport.c | 19 +++++++++++++++++++
    1 file changed, 19 insertions(+)

    --- a/drivers/usb/serial/digi_acceleport.c
    +++ b/drivers/usb/serial/digi_acceleport.c
    @@ -1251,8 +1251,27 @@ static int digi_port_init(struct usb_ser

    static int digi_startup(struct usb_serial *serial)
    {
    + struct device *dev = &serial->interface->dev;
    struct digi_serial *serial_priv;
    int ret;
    + int i;
    +
    + /* check whether the device has the expected number of endpoints */
    + if (serial->num_port_pointers < serial->type->num_ports + 1) {
    + dev_err(dev, "OOB endpoints missing\n");
    + return -ENODEV;
    + }
    +
    + for (i = 0; i < serial->type->num_ports + 1 ; i++) {
    + if (!serial->port[i]->read_urb) {
    + dev_err(dev, "bulk-in endpoint missing\n");
    + return -ENODEV;
    + }
    + if (!serial->port[i]->write_urb) {
    + dev_err(dev, "bulk-out endpoint missing\n");
    + return -ENODEV;
    + }
    + }

    serial_priv = kzalloc(sizeof(*serial_priv), GFP_KERNEL);
    if (!serial_priv)

    \
     
     \ /
      Last update: 2016-04-10 21:01    [W:4.502 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site